Skip to content

Conversation

@Ruksan12
Copy link

For review and upgrading

Copy link
Owner

@TheCSharpAcademy TheCSharpAcademy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ruksan12 Thanks for submitting the project! It's looking good, except that there's a bug, in your divisions if your range is 0, 99 sometimes this will happen and the app crashes:


Image


Also this is not a requirement but it would be good if you'd handle the case where the user doesn't input an integer when answering a question. At the moment the app also crashes. Ideally you want to prevent this and show the user a meaningful error message instead of letting the app crash:


Image

Please fix the bug and optionally add validation so we can approve 😎

@TheCSharpAcademy TheCSharpAcademy self-assigned this Jan 31, 2026
@TheCSharpAcademy
Copy link
Owner

@Ruksan12 Project approved! 😄✅ It's a shame you didn't complete the challenges this time. 😟 It's always a good use of your time. But nothing stops you from revisiting the project later.

🗺️Don't forget you need to submit your Free Code Camp certificate to get your 🟩🟩 Green Belt. You can see the requirements for each belt here.

🔍️In terms of feedback, the main thing: I highly recommend you learn about the DRY Principle (Don't Repeat Yourself) . It's the most important challenge in this project. Your code is neatly organized but there's a lot of repetition for generating the games. You should be able to have all games using just one method.

🔍️Also, consider clearing the console after each operation as it gets crowded quickly:


image

🔍️At the moment you create a new Random() for each game. It's best practice to use a shared static Random or the generated numbers will be less random then expected.

👪Oh and if possible join our Discord Community and add your username to your profile so you can be part of the community as well. 😁 And do you mind adding a country in your profile as well? The dashboard and leaderboard look neater when there's a flag. If you're not comfortable with that you can submit a random country.

☕🍵 If you think we're being helpful, consider contributing with a donation, any amount helps us keep our free service constantly improving.

✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants